Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE-69 ♻️ mutation hook 에러처리 변경 #69

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

jangmoonwon
Copy link
Contributor

🔖 Issue Ticket

티켓 없음

✍️ Description

Axios 오류 여부, 여러 종류의 오류를 던지는 경우여서 axiosError -> isAxiosError로 변경

✅ Checklist

PR

  • Branch Convention 확인

epic/ 에픽, feat/ 피쳐, fix/ 버그 수정, refactor/ 개선

  • Base Branch 확인
  • 적절한 Label 지정
  • Assignee 및 Reviewer 지정

Test

  • 로컬 작동 확인

Additional Notes

  • (없음)

@jangmoonwon jangmoonwon added Priority: Medium 🔖 우선순위 보통 Type: Refactor ♻️ 리팩토링 labels Jul 24, 2024
@jangmoonwon jangmoonwon requested a review from a team July 24, 2024 11:11
@jangmoonwon jangmoonwon self-assigned this Jul 24, 2024
onError: (error: AxiosError) => {
if (!error.response) {
onError: (error) => {
if (!isAxiosError(error)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@jangmoonwon jangmoonwon merged commit 8a35cf2 into feat/FE-69 Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium 🔖 우선순위 보통 Type: Refactor ♻️ 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants